Skip to content

ci: harden windows static export readiness #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrei-ng merged 1 commit into from
Jun 2, 2026
+7 −7
Merged

ci: harden windows static export readiness #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions plotly_static/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,7 @@ impl AsyncStaticExporter {
client.goto(&url).await?;

#[cfg(target_os = "windows")]
Self::wait_for_document_ready(&client, std::time::Duration::from_secs(10)).await?;
Self::wait_for_document_ready(&client, std::time::Duration::from_secs(20)).await?;

// Wait for Plotly container element
#[cfg(target_os = "windows")]
Expand Down Expand Up @@ -1200,13 +1200,13 @@ impl AsyncStaticExporter {
if has_el.as_bool().unwrap_or(false) {
return Ok(());
}
if start.elapsed() > timeout {
return Err(anyhow!(
"Timeout waiting for #plotly-html-element to appear in DOM"
));
}
tokio::time::sleep(std::time::Duration::from_millis(50)).await;
}
if start.elapsed() > timeout {
return Err(anyhow!(
"Timeout waiting for #plotly-html-element to appear in DOM"
));
}
tokio::time::sleep(std::time::Duration::from_millis(50)).await;
}

#[cfg(target_os = "windows")]
Expand Down
Loading