ci: harden windows static export readiness#403
Open
RedZapdos123 wants to merge 1 commit into
Open
Conversation
A flaky windows-latest Chrome CI run timed out waiting for document.readyState during image_to_svg_string even though the page finished loading immediately afterward. Increase the Windows-only document readiness timeout and fix the plotly container wait loop so the timeout path behaves as intended. Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
RedZapdos123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A flaky
windows-latestChrome CI run timed out waiting fordocument.readyStateduringplot::tests::image_to_svg_stringeven though the page finished loading immediately afterward.This PR slightly hardens the Windows-only static export readiness path by widening the Windows-only
document.readyStatewait and fixing the#plotly-html-elementtimeout loop so the timeout path behaves as intended.Checklist:
cargo +nightly fmt --all -- --checkin WSL.cargo test -p plotly plot::tests::image_to_svg_string --features plotly_ndarray,plotly_image,static_export_chromedriver,debug -- --nocapturein WSL.