fix: match import glob common base by path segment#22558
Open
jiyujie2006 wants to merge 2 commits into
Open
Conversation
sapphi-red
reviewed
Jun 1, 2026
Member
sapphi-red
left a comment
There was a problem hiding this comment.
Would you also add an e2e test to https://github.com/vitejs/vite/blob/main/playground/glob-import/__tests__/glob-import.spec.ts ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getCommonBasecurrently checks common directories withstartsWith, so/a/foois treated as a common base for/a/fooand/a/foobar. This can pass a too-narrowcwdto glob matching when directory names share a string prefix.This changes the check to require a full path segment match, and adds coverage for the prefix case.
Additional context
Verified with:
pnpm --filter vite buildpnpm exec vitest run packages/vite/src/node/__tests__/plugins/importGlob/utils.spec.tspnpm exec eslint --no-cache packages/vite/src/node/plugins/importMetaGlob.ts packages/vite/src/node/__tests__/plugins/importGlob/utils.spec.ts