fix(css): include file name in CSS minification warnings and errors#22524
Open
AliMahmoudDev wants to merge 1 commit into
Open
fix(css): include file name in CSS minification warnings and errors#22524AliMahmoudDev wants to merge 1 commit into
AliMahmoudDev wants to merge 1 commit into
Conversation
Currently, CSS minification warnings from esbuild and lightningcss do not include the source file name, making them hard to track down in projects with many CSS modules. Fixes vitejs#15915 Changes: - esbuild warnings: prepend file name from warning.location.file to each formatted warning message - esbuild errors: include file name in error message - lightningcss warnings: include filename in warning prefix - lightningcss errors: include filename in error message
Author
|
Hi maintainers! Just wanted to note that the zizmor CI failure on this PR is caused by a pre-existing issue in All other checks (Build & Test, Lint) are passing. The PR only modifies CSS minification warning/error formatting in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15915
CSS minification warnings from both esbuild and lightningcss currently do not include the source file name in the warning/error message. This makes it extremely difficult to track down which CSS file caused the issue, especially in large projects with many CSS modules.
Before:
After:
Changes
file:prefix fromwarning.location.fileto each formatted warning messagefilenamein the[lightningcss minify]prefixfilenamein error messageBefore/After Comparison
[esbuild css minify]\nWARNING: Unexpected "{"[esbuild css minify]\nstyle.css: WARNING: Unexpected "{"[lightningcss minify] Unexpected nesting[lightningcss minify] style.css\n Unexpected nesting[esbuild css minify] ERROR: ...[esbuild css minify] style.css\n ERROR: ...[lightningcss minify] ERROR: ...[lightningcss minify] style.css\n ERROR: ...