fix(config): rewrite './' base to '/' for server environments#22520
Open
itsybitsybootsy wants to merge 1 commit into
Open
fix(config): rewrite './' base to '/' for server environments#22520itsybitsybootsy wants to merge 1 commit into
itsybitsybootsy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #21812
build.ssr: truerewritesbase: './'to'/', but the new environment API check (consumer === 'server') doesn't, so env-API server builds use./as the base.import.meta.urlcan't handle./on the server.Extended the rewrite to any environment with
consumer: 'server'. Client environments still get./from the outer check.toOutputFilePathWithoutRuntimestill readsconfig.build.ssrdirectly. Only matters for server-side HTML/CSS emit, which doesn't happen in practice, so leaving it.Tests in
config.spec.tscover the env-API server case, legacybuild.ssr: true, client fall-through, and non-shortcut bases.