fix: prevent nanosecond overflow in OTLP timestamps#3798
Conversation
Multiply after BigInt conversion to avoid IEEE 754 precision loss. Affects 4 locations where epoch-ms * 1e6 exceeds Number.MAX_SAFE_INTEGER. Fixes triggerdotdev#3292
|
|
Hi @deepshekhardas, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis pull request refactors nanosecond timestamp conversions across the event repository and run engine handlers to improve arithmetic precision. Functions in Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| ## What | ||
|
|
||
| This PR updates route components to use the animated Resizable panel pattern: | ||
| - Converts conditionally-rendered panels to always-mounted animated panels with `collapsible`, `collapsed`, and `collapseAnimation` props | ||
| - Adds `useFrozenValue` hook usage to keep last selected item visible during panel collapse animation | ||
| - Minor UI polish on logs, runs, schedules, waitpoints pages | ||
|
|
||
| ## Changes | ||
|
|
||
| - **Resizable.tsx** — skipped (main already has these exports) | ||
| - **Route files** (logs, runs, schedules, batches, etc.) — convert panel pattern, add `useFrozenValue` | ||
| - **LogsTable, TreeView, GitMetadata** — minor improvements | ||
|
|
||
| ## Manual resolution | ||
|
|
||
| Merge had 3 conflicts: | ||
| - `Resizable.tsx`: kept main's version (already has animated panel exports with Firefox workarounds) | ||
| - `logs/route.tsx` line 419: removed pointless `?? undefined` (PR's cleaner version) | ||
| - `runs.$runParam/route.tsx`: kept `panel-run-parent-v3` autosaveId, removed `?? undefined` | ||
|
|
||
| ## Original PRs | ||
| - Original: #3267 | ||
| - This replaces: #3319 | ||
|
|
||
| Co-authored-by: James Ritchie <james@trigger.dev> |
There was a problem hiding this comment.
🚩 Accidentally committed pr-body-*.txt files unrelated to this fix
The files pr-body-3321.txt and pr-body-3322.txt at the repository root describe entirely unrelated PRs (#3321 about animated Resizable panels, #3322 about OpenClaw agent integration). These appear to have been accidentally committed alongside the BigInt fix and should be removed before merge to avoid polluting the repository root with unrelated documentation.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Fixes #3292
Multiply after BigInt conversion in 4 locations where epoch-ms * 1e6 exceeds Number.MAX_SAFE_INTEGER, causing ~256ns precision errors in ~0.2% of cases.
Changes:
unEngineHandlers.server.ts:467\ - retry event recording