Add configValidation to DattoRMM plugin#46
Conversation
Adds a connection test step so users get immediate feedback on whether their Base URL, API Key, and API Secret are valid during plugin setup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
clarkd
left a comment
There was a problem hiding this comment.
Claude should flag this too but you'll need to bump the version number - otherwise looks good!
|
@claude review this |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
🔍 Validation Details✅
|
There was a problem hiding this comment.
Version bump has been applied addressing my previous feedback — straightforward addition of a configValidation step.
Extended reasoning...
Overview
This PR adds a single configValidation.json file to the DattoRMM plugin and bumps the version in metadata.json from 1.0.1 to 1.0.2. The validation step reuses the existing importSites data stream to test connectivity during plugin setup. Total diff is ~12 lines.
Security risks
None. No credentials, secrets, or auth changes. The configValidation uses an existing data stream that already handles auth via the established OAuth2 flow defined in metadata.json. No new endpoints or attack surface.
Level of scrutiny
Low. This is exactly the kind of mechanical, pattern-following change that doesn't need human review: a small JSON file that follows the established configValidation pattern used by other plugins in the repo, plus a patch-level version bump. The schema is correct (steps array with displayName, dataStream, success, error, required fields).
Other factors
My previous review on 2026-05-12 flagged the missing version bump. The author has now addressed that feedback (1.0.1 → 1.0.2). CI validation passed (Config Validation: true in the bot summary). No outstanding reviewer comments remain unaddressed.
📋 Summary
Adds a
configValidation.jsonto the DattoRMM plugin so users get a connection test step during plugin setup. It validates the Base URL, API Key, and API Secret by exercising the existingimportSitesdata stream (callsapi/v2/account/sites).🔗 Related issue(s)
🧩 Plugin details
Does this PR introduce any breaking changes?
📚 Documentation
✅ Checklist