fix(falcon/async_resource): replace the use of removed resp.body#1516
Conversation
|
Thanks for the contribution! Before we can merge this, we need @vytas7 to sign the Salesforce Inc. Contributor License Agreement. |
| return | ||
|
|
||
| resp.status = "404" | ||
| # Falcon 4.x w/ mypy fails to correctly infer the str type here |
There was a problem hiding this comment.
Mypy was actually functioning correctly - resp.body was removed long ago.
(All this could be replaced with a onliner raising HTTPNotFound, especially if you're OK with a JSON error.)
|
(I believe I have now signed the CLA.) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
==========================================
+ Coverage 91.30% 91.36% +0.05%
==========================================
Files 228 228
Lines 7271 7275 +4
==========================================
+ Hits 6639 6647 +8
+ Misses 632 628 -4 ☔ View full report in Codecov by Sentry. |
|
Thanks for this contribution and interest in our project 🙏 Sometimes we need to close and reopen the issue to force the CLA tool to retrigger |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Thanks for your time an interest in our project 🙏
I mirrored the changes in the sync implementation and added unit tests to cover this logic
Summary
Testing
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.