Skip to content

Update sentinel#757

Merged
JelleZijlstra merged 12 commits into
python:mainfrom
zedzhen:patch-1
Jun 2, 2026
Merged

Update sentinel#757
JelleZijlstra merged 12 commits into
python:mainfrom
zedzhen:patch-1

Conversation

@zedzhen
Copy link
Copy Markdown
Contributor

@zedzhen zedzhen commented May 19, 2026

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented May 19, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@HexDecimal
Copy link
Copy Markdown
Contributor

I assume the repr keyword should be added to the sentinel docs at doc/index.rst, and the versionchanged directive should be updated to clarify that only positional repr is deprecated.

@HexDecimal
Copy link
Copy Markdown
Contributor

HexDecimal commented May 19, 2026

The typing.Optional[str] parameter not acknowledging None is invalid and also breaks backwards compatibility.

Comment thread src/typing_extensions.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.19%. Comparing base (404b33b) to head (3c420b0).

Files with missing lines Patch % Lines
src/test_typing_extensions.py 83.33% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   97.21%   97.19%   -0.02%     
==========================================
  Files           3        3              
  Lines        7797     7815      +18     
==========================================
+ Hits         7580     7596      +16     
- Misses        217      219       +2     
Flag Coverage Δ
3.10 88.94% <91.66%> (-0.01%) ⬇️
3.10.4 88.94% <91.66%> (-0.01%) ⬇️
3.11 88.18% <91.66%> (+<0.01%) ⬆️
3.11.0 87.43% <91.66%> (+<0.01%) ⬆️
3.12 88.13% <91.66%> (+<0.01%) ⬆️
3.12.0 88.12% <91.66%> (+<0.01%) ⬆️
3.13 82.94% <91.66%> (+0.01%) ⬆️
3.13.0 83.65% <91.66%> (+0.01%) ⬆️
3.14 79.04% <91.66%> (+0.02%) ⬆️
3.9 89.64% <91.66%> (-0.01%) ⬇️
3.9.12 89.64% <91.66%> (-0.01%) ⬇️
pypy3.10 88.77% <91.66%> (+<0.01%) ⬆️
pypy3.11 88.04% <91.66%> (+<0.01%) ⬆️
pypy3.9 89.47% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/typing_extensions.py 93.95% <100.00%> (+0.03%) ⬆️
src/test_typing_extensions.py 98.15% <83.33%> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/typing_extensions.py Outdated
Comment thread doc/index.rst
Comment thread src/test_typing_extensions.py Outdated
zedzhen and others added 4 commits May 19, 2026 20:03
@zedzhen zedzhen requested a review from JelleZijlstra May 20, 2026 17:09
zedzhen added 2 commits June 2, 2026 10:45
# Conflicts:
#	src/test_typing_extensions.py
#	src/typing_extensions.py
@zedzhen
Copy link
Copy Markdown
Contributor Author

zedzhen commented Jun 2, 2026

@JelleZijlstra, please review this PR.

@JelleZijlstra JelleZijlstra merged commit 7e4fc36 into python:main Jun 2, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt Sentinel implementation to accepted version of PEP 661

3 participants