gh-58370 Document and test frozendict class matching behaviour#150799
Open
da-woods wants to merge 1 commit into
Open
gh-58370 Document and test frozendict class matching behaviour#150799da-woods wants to merge 1 commit into
da-woods wants to merge 1 commit into
Conversation
Frozendict has `_Py_TPFLAGS_MATCH_SELF` set so works correctly with the single-arg class matching. However it isn't documented in the list of classes this works with and it isn't tested. The test is some way below the other similar tests but anything else would need a large renumbering
da-woods
requested review from
AA-Turner,
brandtbucher and
willingc
as code owners
Contributor
Author
|
I'm assuming this is fine to bundle onto the original frozendict issue, but can change that if needed |
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frozendict has
_Py_TPFLAGS_MATCH_SELFset so works correctly with the single-arg class matching. However it isn't documented in the list of classes this works with and it isn't tested.The test is some way below the other similar tests but anything else would need a large renumbering