gh-150751: validate http.client Content-Length and chunk-size#150752
Open
metsw24-max wants to merge 1 commit into
Open
gh-150751: validate http.client Content-Length and chunk-size#150752metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
RFC 9112 defines Content-Length as 1*DIGIT and chunk-size as 1*HEXDIG, but int() also accepts a sign, underscores, surrounding whitespace and an 0x prefix, so malformed framing values were parsed instead of rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed
beginand_read_next_chunk_sizederive the response body framing fromint(length)andint(line, 16), butintalso accepts a leading sign, underscores, surrounding whitespace and an0xprefix that RFC 9112 forbids forContent-Length(1DIGIT) andchunk-size(1HEXDIG). So+5,5_0or a negative chunk size parse cleanly here while a strict front end frames the response differently. This matches both tokens against the grammar before converting.