ext/intl: Preserve int64 precision in IntlNumberRangeFormatter::format()#22202
Open
LamentXU123 wants to merge 1 commit into
Open
ext/intl: Preserve int64 precision in IntlNumberRangeFormatter::format()#22202LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
0826af7 to
cc7b199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now in IntlNumberRangeFormatter::format(), we use
to create ICU Formattable values
The ternary expression doesn't work well because it mix double and zend_long operands, and that will lead to precision lost for obvious reasons. That is
results in
while it should be
The feature is newly added in php 8.6-dev so we don't need to write NEWS and UPGRADING entries.