module: use file: URL as sourceURL for type-stripped CommonJS#63705
Open
joyeecheung wants to merge 1 commit into
Open
module: use file: URL as sourceURL for type-stripped CommonJS#63705joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
The CommonJS loader was passing the bare filesystem path as the `//# sourceURL` comment of type-stripped TypeScript, this leads to two problems: 1. It reports hasSourceURL = false if the path contains any whitespaces as this breaks V8's magic comment parser. 2. The inspector would incorrectly report a file path verbatim as the script's URL. Pass the module's file: URL as the sourceURL so the reported URL is consistent across loaders and won't lead to an issue in inspector clients that actually except a real URL for the scripts. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63705 +/- ##
==========================================
- Coverage 90.35% 90.33% -0.03%
==========================================
Files 732 732
Lines 236684 236686 +2
Branches 44579 44593 +14
==========================================
- Hits 213855 213809 -46
- Misses 14544 14592 +48
Partials 8285 8285
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CommonJS loader was passing the bare filesystem path as the
//# sourceURLcomment of type-stripped TypeScript, this leads to two problems:hasSourceURL = falseif the path contains any whitespaces as this breaks V8's magic comment parser.Pass the module's file: URL as the sourceURL so the reported URL is consistent across loaders and won't lead to an issue in inspector clients that actually except a real URL for the scripts.