fix(auth): add Accept: application/json header to OAuth token requests#2754
Open
sohammmmm10 wants to merge 1 commit into
Open
fix(auth): add Accept: application/json header to OAuth token requests#2754sohammmmm10 wants to merge 1 commit into
sohammmmm10 wants to merge 1 commit into
Conversation
Token exchange and refresh requests only set Content-Type but omit the Accept header. Some OAuth providers (e.g. GitHub) return form-encoded data by default and require Accept: application/json to return JSON. Since _handle_token_response parses the body as JSON, omitting the Accept header causes parse failures with these providers. Add Accept: application/json to both _exchange_token_authorization_code and _build_refresh_token_request. Fixes modelcontextprotocol#1523
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token exchange and refresh requests only set Content-Type but omit the Accept header. Some OAuth providers (e.g. GitHub) return form-encoded data by default and require Accept: application/json to return JSON. Since _handle_token_response parses the body as JSON, omitting the Accept header causes parse failures with these providers.
Add Accept: application/json to both _exchange_token_authorization_code and _build_refresh_token_request.
Fixes #1523
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context