[WC-3322]: Fix range-slider decimal places formatting#2239
Open
samuelreichert wants to merge 1 commit into
Open
[WC-3322]: Fix range-slider decimal places formatting#2239samuelreichert wants to merge 1 commit into
samuelreichert wants to merge 1 commit into
Conversation
…imal places Replace raw .toString() / number in mark labels and numeric tooltips with createValueFormatter — the same pattern used in slider-web. Marks use lowerBoundAttribute.formatter; each tooltip handle uses its own formatter (lower for index 0, upper for index 1). The locale decimal separator, thousands grouping, and decimalPlaces are now all respected. Add unit tests for createValueFormatter (helpers.spec.ts) and createMarks (marks.spec.ts) mirroring the slider-web coverage. Update editorPreview to pass a deterministic preview formatter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
range-slider-webto parity withslider-web's locale-aware number formattingNumberFormatterinstead of raw.toString(), respectingdecimalPlaces, decimal separator, and thousands grouping per session localelowerBoundAttributefor index 0,upperBoundAttributefor index 1)