feat(browser_pools): typed acquire helper distinguishing got / timed-out#107
Draft
Jayko001 wants to merge 4 commits into
Draft
feat(browser_pools): typed acquire helper distinguishing got / timed-out#107Jayko001 wants to merge 4 commits into
Jayko001 wants to merge 4 commits into
Conversation
Add `kernel.lib.browser_pools.acquire` (and `acquire_async`) returning a typed discriminated union — `Acquired(browser)` on 200 or `TimedOut()` on 204 — so callers can disambiguate the long-poll timeout from a successful lease without inspecting the raw HTTP status. 404 continues to raise the existing `NotFoundError`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds PoolNotFound to AcquireResult and catches NotFoundError internally so all three documented outcomes — Acquired, TimedOut, PoolNotFound — are reachable via the same isinstance() switch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AsyncAPIResponse.parse() is itself async; without await we constructed Acquired with a coroutine instead of the parsed model. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed wrapper around
client.browser_pools.acquireso callers can distinguish a successful lease from a long-poll timeout without inspecting raw HTTP status codes.Acquired(browser)— 200, browser leased from poolTimedOut()— 204, long poll expired, retryNotFoundError— 404, pool does not exist (existing exception, propagated)Sync (
acquire) and async (acquire_async) variants are provided. The generatedclient.browser_pools.acquire()method is unchanged for backwards compatibility.Test plan