Set defaults for date/time picker and timezone#1996
Open
asarj wants to merge 3 commits into
Open
Conversation
Contributor
Author
Manual Steps to test after launching a JupyterLab instance
Test the create modal:
Test saving without a date:
Test saving with a date:
Test the edit modal:
|
Author
|
hi @brichet can you please trigger the CI checks again? |
Author
|
Seems the lone failing test was due to 20 min timeout, is it permissible to increase the timeout to something longer (like 30 mins) or somehow increase the number of workers that execute CI tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1884
The due date picker in the formgrader's "Manage Assignments" page had two UX issues: the time component defaulted to the current time instead of midnight, and the timezone field was empty in the create modal. Faculty would unintentionally save inconsistent due times like
14:37when they only changed the date.Changes
00:00(using a one-timefocushandler so users who skip the field get no due date)Tests
test_get_assignment_custom_timezone: verifies non-UTC timezone propagationDue date defaults: validates midnight default on focus, timezone pre-fill, and no-date regressionManual verification
00:00Per the pull request guidelines: