Avoid shell parsing for Python helper commands#327
Open
StantonMatt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkSyntaxFile,getVersion, andgetVersionSyncwith argument-vectorexecFilecallsgetVersion(),getVersionSync(), andcheckSyntaxFile()paths containing spacesFixes #181.
Why
The previous implementation built commands like
${pythonPath} --version. That breaks when the Python executable path contains spaces and also leaves these helpers dependent on shell parsing. Passing the executable and arguments separately avoids quoting issues.Verification
npm test -- --grep "path contains spaces|executable path contains spaces"npm testnpx prettier --check index.ts test/test-python-shell.tsgit diff --checkreview-fix-loop: clean, no introduced correctness/security/maintainability issues