Propagate JSON parse errors#326
Open
StantonMatt wants to merge 1 commit into
Open
Conversation
|
I checked the core path locally.
The implementation looks directionally correct to me. Keeping parse failures on a separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messageeventsparseErrorevent and pass the first parse failure to.end()/PythonShell.run()so callers can handle invalid JSON outputmessagelistener exceptions outside the parser catch path so normal EventEmitter behavior is preservedFixes #253.
Validation
npm test -- --grep "parseError|JSON output"npm testgit diff --checkreview-fix-loopclean after addressing one reviewer finding