chore: remove IE 11 support#1003
Conversation
|
Hi @amareshsm!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
amareshsm
changed the title
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
This pull request was auto-closed due to inactivity. While we wish we could keep working on every request, we unfortunately don't have the bandwidth to continue here and need to focus on other things. You can resubmit this pull request if you would like to continue working on it. |
There was a problem hiding this comment.
Pull request overview
Removes legacy Internet Explorer 11 compatibility code from the ESLint.org site by deleting polyfills and pruning IE-specific CSS/markup, simplifying the frontend assets shipped to browsers.
Changes:
- Removed IE-related scripts from the base layout and deleted legacy polyfill files.
- Dropped IE-specific SCSS selectors and vendor-prefixed/high-contrast fallbacks, favoring modern standards (e.g., native
:focus-visible,forced-colors). - Cleaned up remaining IE-only CSS prefixes (
-ms-*) across components.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/_includes/layouts/base.html | Removes X-UA-Compatible and stops loading legacy polyfill scripts. |
| src/assets/scss/foundations.scss | Removes .focus-visible / .js-focus-visible fallbacks; relies on native focus styling. |
| src/assets/scss/forms.scss | Removes IE-specific select/search/checkbox styling fallbacks. |
| src/assets/scss/components/slider.scss | Removes .js-focus-visible focus fallback selector. |
| src/assets/scss/components/popup.scss | Removes .focus-visible / .js-focus-visible focus fallback selectors. |
| src/assets/scss/components/search.scss | Removes IE-specific ::-ms-clear / ::-ms-reveal rules. |
| src/assets/scss/components/playground-configuration.scss | Removes -ms-transform usage. |
| src/assets/scss/components/accordion.scss | Removes -ms-transform usage. |
| src/assets/scss/branding.scss | Removes .focus-visible class-based fallback styling. |
| src/assets/scss/syntax-highlighter.scss | Removes -ms-hyphens vendor prefix. |
| src/assets/js/css-vars-ponyfill@2.js | Deletes CSS variables ponyfill. |
| src/assets/js/focus-visible.js | Deletes :focus-visible polyfill. |
| src/assets/js/intersectionObserver-polyfill.js | Deletes IntersectionObserver polyfill. |
| src/assets/js/inert-polyfill.js | Deletes inert polyfill. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| outline-offset: 3px; | ||
| } | ||
|
|
||
| *.focus-visible { | ||
| outline: 2px solid var(--outline-color); | ||
| outline-offset: 3px; | ||
| } | ||
|
|
||
| *:focus:not(:focus-visible) { | ||
| outline: 1px solid transparent; |
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I personally like this change, but since :focus-visible has been widely available since 2022, some may feel that dropping browsers released before then is a bit restrictive. I’d like to raise this for further discussion with future reviewers.
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Selectors/:focus-visible
|
Changes LGTM, but I found an additional polyfill which should be removed in src/assets/js/slider.js#2-29.
|
Makes sense to me 👍 |
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Removed the X-UA-Compatible meta tag from the base layout.
Deleted the IE polyfill scripts:
- css-vars-ponyfill@2.js (ponyfill for CSS variables)
- focus-visible.js (polyfill for :focus-visible)
Removed polyfill-specific CSS selectors and JS-class fallbacks from SCSS:
- Eliminated .focus-visible and .js-focus-visible usages where the native :focus-visible selector is already present.
Updated base.html to load only main.js (no polyfills).
Related Issues
Is there anything you'd like reviewers to focus on?