Fix dor help <command> to show the command's help#122
Open
dormouse-bot wants to merge 1 commit into
Open
Conversation
`dor help split` (and other subcommands) printed the root help, dropping the subject. `dor split --help` worked as expected. Map `help <command>` to `<command> --help` and update the help-target resolver to match, so the two forms produce identical output. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
d920639
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://922d7035.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-dor-help-subcommand.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dor help split(and other subcommands) silently dropped the subject and showed the root help.dor split --helpworked fine. After this change,dor help <command>shows the same output asdor <command> --help.Two small changes in
dor/src/cli.ts:runCliargv rewrite handleshelp <command>(washelponly).getHelpTargetrecogniseshelp <command>as a command-scoped target, so the help patches apply.Unknown subjects (
dor help nope) still fall through to root help, matching the prior behaviour.Test plan
pnpm --filter dor test— added one regression check per command (dor help <command>matchesdor <command> --help), plus an unknown-subject assertion. All 23 tests pass.node dor/dist/dor.js help splitandhelp ensurenow match their--helpcounterparts.