Attempt to fix Windows CMake build#656
Closed
hibell wants to merge 2 commits into
Closed
Conversation
Collaborator
|
@hibell it's possible your empty commit is not sufficient to trigger the CI, try adding a newline to a C file or something like that? |
Author
|
@notroj Thanks that might've did the trick. I wasn't sure if it was because PR was marked as draft or not or maybe I just needed a new commit after going through the GH onboarding process. |
hibell
force-pushed
the
fix-windows-build
branch
3 times, most recently
from
f5314c7 to
bd63a2d
Compare
Author
|
Closing. #659 fixes the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.