Remove the duplicate configkey json.content.type#13264
Conversation
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13264 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01%
+ Complexity 13433 13432 -1
============================================
Files 5665 5666 +1
Lines 500572 500626 +54
Branches 60792 60796 +4
============================================
+ Hits 81417 81425 +8
- Misses 410047 410092 +45
- Partials 9108 9109 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18061 |
| @@ -1673,7 +1666,6 @@ public ConfigKey<?>[] getConfigKeys() { | |||
| ConcurrentSnapshotsThresholdPerHost, | |||
| EncodeApiResponse, | |||
| EnableSecureSessionCookie, | |||
There was a problem hiding this comment.
@sureshanaparti it seems that we're missing the JSONContentType ConfigKey in a getConfigKeys() method. Could you add it here?
Description
This PR removes the duplicate configkey json.content.type. Preserved the same description for the config as now in the CloudStack deployment.
The config key was added twice here: https://github.com/apache/cloudstack/pull/2848/files#diff-d4f381fc49d5bb07c76daf73677484cace911ff56eb08e60b253b6ef0273124d (in 4.12.0.0) and one config key is unused.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?