fix: remove conditional dialog mounts; bump @chakra-ui/react to ^3.35.0#67796
Open
sridhar-3009 wants to merge 1 commit into
Open
fix: remove conditional dialog mounts; bump @chakra-ui/react to ^3.35.0#67796sridhar-3009 wants to merge 1 commit into
sridhar-3009 wants to merge 1 commit into
Conversation
….35.0
Ark UI 5.36 moved the pointer-events cleanup from an inline DOM style to
the dismissable layer's close-transition callback. Conditionally mounted
dialogs ({open ? <Dialog/> : undefined}) unmount before that transition
fires, leaving pointer-events:none stuck on document — all button/link
clicks stop working until a full page refresh.
Fix: always render the affected dialogs; control visibility via the open
prop. Reset local state (note, selectedOptions, preventRunningTask) via
useEffect on open→false so re-opening shows the server value, not what
the user typed before cancelling (preserves the behaviour that motivated
the conditional mount in the first place).
Affected components:
- Clear/Run/ClearRunButton + ClearRunDialog
- Clear/TaskInstance/ClearTaskInstanceButton + ClearTaskInstanceDialog
- MarkAs/Run/MarkRunAsButton + MarkRunAsDialog
- MarkAs/TaskInstance/MarkTaskInstanceAsButton + MarkTaskInstanceAsDialog
- pages/TaskInstance/Header (clearOpen guard)
Also bumps @chakra-ui/react from ~3.34.0 to ^3.35.0 and removes the
now-resolved CONTRIBUTING.md caveat section.
Closes apache#67647
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #67647.
Ark UI 5.36 moved
pointer-eventscleanup from an inline DOM style to the dismissable layer's close-transition callback. Dialogs that were conditionally mounted ({open ? <Dialog/> : undefined}) unmounted before that transition ran, leavingpointer-events: nonepermanently stuck ondocument— every button/link click was silently swallowed until a hard refresh.Root cause
The conditional mount pattern was intentional: unmounting reset
useState(note, selectedOptions, etc.) so re-opening the dialog showed the server value, not the user's uncommitted input. Ark UI 5.36 made this pattern incompatible with the new cleanup approach.Fix
Buttons — remove the
openguard; always render the dialog:Dialogs — add
useEffectto reset local state whenopengoesfalse:This preserves the note-reset behaviour (#47071) while letting the dialog drive its own close transition.
Affected files
Clear/Run/ClearRunButton.tsx+ClearRunDialog.tsxClear/TaskInstance/ClearTaskInstanceButton.tsx+ClearTaskInstanceDialog.tsxMarkAs/Run/MarkRunAsButton.tsx+MarkRunAsDialog.tsxMarkAs/TaskInstance/MarkTaskInstanceAsButton.tsx+MarkTaskInstanceAsDialog.tsxpages/TaskInstance/Header.tsxpackage.json:~3.34.0→^3.35.0CONTRIBUTING.md: remove now-resolved caveat sectionVerification checklist