fix: correct misleading error message in MidpointIntegration#1902
Open
shaked-shlomo wants to merge 1 commit into
Open
fix: correct misleading error message in MidpointIntegration#1902shaked-shlomo wants to merge 1 commit into
shaked-shlomo wants to merge 1 commit into
Conversation
The validation throws when N <= 0, and the docstring states 'N must be > 0', but the message claimed 'N has to be >= 2'. N = 1 is valid for the midpoint rule, so the message now matches the actual check. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1902 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 379 379
Lines 19778 19778
Branches 3016 3016
=======================================
Hits 16993 16993
Misses 2785 2785 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
Maths/MidpointIntegration.jsthe guard rejects non-positiveN:The thrown message says
'N has to be >= 2', but:N <= 0,check if N > 0, andN = 1is a valid number of subintervals for the midpoint rule, so the>= 2message is incorrect and misleading. This changes it to'N has to be > 0'to match the actual validation and the documentation.(Note: the analogous
>= 2message inSimpsonIntegration.jsis correct there, since Simpson's rule additionally requires an evenN, so the minimum is 2 — left unchanged.)Checklist
🤖 Generated with Claude Code