rsbuild blog post#957
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new blog post announcing first-class Rsbuild 2 support for TanStack Start, describing the ChangesRsbuild 2 Integration Blog Post
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/blog/start-adds-rsbuild-support.md`:
- Around line 1-8: The frontmatter is missing the required excerpt field causing
build validation to fail; open the frontmatter in start-adds-rsbuild-support.md
and add an excerpt: a short 1–2 sentence string under the existing
title/description fields using the key excerpt so the frontmatter contains
excerpt: "..." (ensure it's a plain string, not null/undefined) to satisfy the
pipeline validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cf8da816-3839-4fa8-ae16-da43032ee391
⛔ Files ignored due to path filters (1)
public/blog-assets/start-adds-rsbuild-support/header.jpgis excluded by!**/*.jpg
📒 Files selected for processing (1)
src/blog/start-adds-rsbuild-support.md
schiller-manuel
force-pushed
the
rsbuild-blog
branch
from
d5948af to
83d15fb
Compare
|
|
||
| Rsbuild owns the build, while the framework plugin handles React or Solid and `tanstackStart()` wires Start into both the client and server builds. If you have used Start with Vite, the pattern is intentionally familiar because the Start build-tool plugins are designed to fit naturally into the toolchain you choose. | ||
|
|
||
| ## Why another build tool matters |
There was a problem hiding this comment.
"Why this matters" ai-ism. I'm fine with it, but just pointing it out in case.
|
|
||
| Because the first Start build adapter was Vite, some build logic naturally grew around Vite's plugin lifecycle, and adding Rsbuild made the boundary sharper: shared Start build behavior in one place, build-tool-specific behavior in the Vite and Rsbuild adapters. | ||
|
|
||
| ## The Rsbuild adapter has full feature parity |
There was a problem hiding this comment.
I think this section could just be rolled into another section. Still good, but doesn't need it's own section.
|
|
||
| ## Built with the Rsbuild and Rspack team | ||
|
|
||
| The TanStack team built the adapter in close collaboration with the Rsbuild and Rspack team, and the work fed back into both projects. |
There was a problem hiding this comment.
This section might also be able to be reduces and moved around. Maybe some of it can go up front like the "collaborative" aspect.
2 participants
Summary by CodeRabbit