feat(manifest): default to Socket facts, delegate generation to Coana CLI#1352
Draft
Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 1 commit into
Conversation
… CLI
Make `socket manifest {gradle,kotlin,scala,auto}` emit `.socket.facts.json`
by default; add `--pom` for the legacy pom.xml generation. `--facts` is still
accepted (it is now the default) and socket.json `facts: false` still selects
pom generation.
Facts generation now delegates to the Coana CLI's `manifest gradle|sbt`
command (the Gradle init script and sbt plugin live in Coana now), forwarding
--bin/--configs/--ignore-unresolved/--gradle-opts/--sbt-opts via spawnCoanaDlx
(which honors SOCKET_CLI_COANA_LOCAL_PATH for local builds).
Remove the now-dead bundled socket-facts.init.gradle, the sbt plugin, their
rollup copy steps, and the ported gradle-facts test fixtures. The pom-path
init.gradle is unchanged.
REA-507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
socket manifest {gradle,kotlin,scala,auto}emit.socket.facts.jsonby default and add--pomfor the legacy pom.xml generation.manifest gradle|sbtcommand viaspawnCoanaDlx(which honorsSOCKET_CLI_COANA_LOCAL_PATH). socket-cli no longer runs gradle/sbt itself for the facts path; the build-tool resolution scripts live in Coana.coana-manifest-facts.mts;convert-gradle-to-facts/convert-sbt-to-factsare now thin wrappers.--pomopts into pom.xml generation.--factsis still accepted (it's the default); socket.jsonfacts: falsestill selects pom; passing--facts --pomtogether warns and generates facts.socket manifest autoflipped to match.socket-facts.init.gradle, the sbt plugin, their rollup copy steps, and thegradle-factstest fixtures (ported to Coana). The pom-pathinit.gradleis unchanged.The resolved artifact-paths sidecar (file paths used for reachability) stays internal to Coana —
socket manifestonly requests the uploadable facts file.Blocked — do not merge yet
Depends on the Coana side (REA-509) shipping the
manifestcommands. The currently pinned@coana-tech/clidoes not have them, so this is mergeable only after:manifest gradle|sbt, and@coana-tech/cliis bumped in this repo.Until then it works locally via
SOCKET_CLI_COANA_LOCAL_PATH.Testing
check:tsc,check:lint, Biome clean; full unit suite passing (help snapshots + auto-manifest tests updated).socket manifest gradle(no flags) against a Gradle (Fabric Loom) test project delegates to a local Coana build and produces the expected.socket.facts.json.Linear: REA-507 (related: REA-509)