docs(scan): drop stale NPM caveat from --reach-concurrency help#1351
Merged
Martin Torp (mtorp) merged 1 commit intoJun 1, 2026
Merged
Conversation
NPM reachability now supports concurrent execution, so the note that the concurrency level is ignored for NPM is no longer accurate. Remove that sentence from the --reach-concurrency flag description and update the two inline help-output expectations in the scan create/reach tests.
Benjamin Barslev Nielsen (barslev)
approved these changes
Jun 1, 2026
auto-merge was automatically disabled
June 1, 2026 09:02
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the now-stale sentence from the
--reach-concurrencyflag help:NPM reachability now supports concurrent execution, so the caveat is no longer accurate. The flag description now reads:
Changes
src/commands/scan/reachability-flags.mts— drop the NPM caveat from thereachConcurrencydescription.src/commands/scan/cmd-scan-create.test.mts/src/commands/scan/cmd-scan-reach.test.mts— update the inline--helpoutput expectations to match.Notes
The matching caveat is also being removed upstream in
@coana-tech/cli(which is where this CLI's text mirrors). Once a coana release carrying that change lands, the bundledINLINED_SOCKET_CLI_COANA_TECH_CLI_VERSIONshould be bumped so the runtime help printed by the coana binary matches this flag help too.Test
pnpm test:unit src/commands/scan/cmd-scan-create.test.mts src/commands/scan/cmd-scan-reach.test.mts— 85/85 pass.Note
Low Risk
User-facing help text and test expectations only; no reachability execution or API behavior changes.
Overview
Updates
--reach-concurrencyhelp so it no longer claims NPM reachability ignores concurrency. The flag text now only describes the concurrent run limit and the recommendation to size concurrency against--reach-analysis-memory-limit.reachability-flags.mtscarries the description change;cmd-scan-createandcmd-scan-reachunit tests that snapshot--helpoutput are aligned with the new wording.Reviewed by Cursor Bugbot for commit 476c7e7. Configure here.