[PWGHF] added new file for Xic correlation#16510
Draft
singhra1994 wants to merge 4 commits into
Draft
Conversation
singhra1994
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 2 errors, |
Please consider the following formatting changes to AliceO2Group#16510
vkucera
requested changes
Jun 2, 2026
Comment on lines
+1498
to
+1499
| static constexpr std::size_t NDaughtersXic0 = static_cast<std::size_t>(XicDecayDaughtersCount::Xic0DaughtersCount); | ||
| static constexpr std::size_t NDaughtersXicPlus = static_cast<std::size_t>(XicDecayDaughtersCount::XicPlusDaughtersCount); |
Collaborator
There was a problem hiding this comment.
Why do you need these aliases?
Comment on lines
+16
to
+27
| #include "PWGHF/Core/DecayChannels.h" | ||
| #include "PWGHF/Core/DecayChannelsLegacy.h" | ||
| #include "PWGHF/Core/HfHelper.h" | ||
| #include "PWGHF/Core/SelectorCuts.h" | ||
| #include "PWGHF/DataModel/AliasTables.h" | ||
| #include "PWGHF/DataModel/CandidateReconstructionTables.h" | ||
| #include "PWGHF/DataModel/CandidateSelectionTables.h" | ||
| #include "PWGHF/DataModel/TrackIndexSkimmingTables.h" | ||
| #include "PWGHF/HFC/DataModel/CorrelationTables.h" | ||
| #include "PWGHF/HFC/Utils/utilsCorrelations.h" | ||
| #include "PWGHF/Utils/utilsAnalysis.h" | ||
| #include "PWGLF/DataModel/LFStrangenessTables.h" |
Collaborator
There was a problem hiding this comment.
Are you sure you need all these?
Comment on lines
+81
to
+84
| o2physics_add_dpl_workflow(correlator-xic-hadrons | ||
| SOURCES correlatorXicHadrons.cxx | ||
| PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore | ||
| COMPONENT_NAME Analysis) |
Collaborator
There was a problem hiding this comment.
Respect the alphabetical ordering and spacing.
Comment on lines
+169
to
+170
| Filter xic0Filter = aod::hf_sel_toxipi::resultSelections == true; | ||
| template <bool isXicPlus, typename CollType, typename CandType> |
Collaborator
There was a problem hiding this comment.
Suggested change
| Filter xic0Filter = aod::hf_sel_toxipi::resultSelections == true; | |
| template <bool isXicPlus, typename CollType, typename CandType> | |
| Filter xic0Filter = aod::hf_sel_toxipi::resultSelections == true; | |
| template <bool isXicPlus, typename CollType, typename CandType> |
Comment on lines
+268
to
+269
| if (!collision.sel8()) { | ||
| return 0; |
| bool isPrompt = false; | ||
| bool isNonPrompt = false; | ||
| bool isSignal = false; | ||
| TRandom3* rnd = new TRandom3(0); |
Collaborator
There was a problem hiding this comment.
Don't use dynamic memory allocation if you don't have to.
|
|
||
| BinningType corrBinning{{binsZVtx, binsMultiplicity}, true}; | ||
|
|
||
| HistogramRegistry registry{"registry", {}, OutputObjHandlingPolicy::AnalysisObject}; |
Collaborator
There was a problem hiding this comment.
Don't specify the arguments if you are using the default values.
Suggested change
| HistogramRegistry registry{"registry", {}, OutputObjHandlingPolicy::AnalysisObject}; | |
| HistogramRegistry registry{"registry"}; |
Comment on lines
+665
to
+674
| case kXiC0: | ||
| return 0.5f; // Xic0 | ||
| case -kXiC0: | ||
| return -0.5f; // Xic0-bar | ||
| case kXiCPlus: | ||
| return 1.5f; // XicPlus | ||
| case -kXiCPlus: | ||
| return -1.5f; // XicMinus | ||
| default: | ||
| return 0.f; |
Collaborator
There was a problem hiding this comment.
What do the return values mean?
Comment on lines
+709
to
+712
| ROOT::Math::PtEtaPhiMVector vec1(pT1, eta1, phi1, mass1); | ||
| ROOT::Math::PtEtaPhiMVector vec2(particle2.pt(), particle2.eta(), particle2.phi(), mass2); | ||
| ROOT::Math::PtEtaPhiMVector combined = vec1 + vec2; | ||
| return combined.mass(); |
Collaborator
There was a problem hiding this comment.
Why don't you use RecoDecay methods?
Comment on lines
+718
to
+721
| ROOT::Math::PtEtaPhiMVector vec1(pT1, eta1, phi1, 0.); | ||
| ROOT::Math::PtEtaPhiMVector vec2(particle2.pt(), particle2.eta(), particle2.phi(), 0.); | ||
| ROOT::Math::PtEtaPhiMVector combined = vec1 + vec2; | ||
| return combined.pt(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.