-
Notifications
You must be signed in to change notification settings - Fork 661
[PWGLF] NucleiTask - Add INELgt0 and INELgt1 checks on data model #16435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giovannimalfattore
wants to merge
11
commits into
AliceO2Group:master
Choose a base branch
from
giovannimalfattore:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+197
−173
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
eac0024
NucleiTask - Fix error
giovannimalfattore 9151dd5
NucleiTask - Fix bugs in mult dependent histos
giovannimalfattore 8ad53e5
NucleiTask - Add INELgt0 and INELgt1 checks on data model
giovannimalfattore b6b28e3
NucleiTask - Fix variables
giovannimalfattore 8f94641
NucleiTask - Fix variables
giovannimalfattore af3c71c
NucleiTask - Fix O2Lint errors
giovannimalfattore 4b515a9
NucleiTask - Fix O2Lint errors
giovannimalfattore 5678d31
NucleiTask - Fix O2Lint errors
giovannimalfattore 189fb77
NucleiTask - Fix O2Lint errors
giovannimalfattore 2aa2b5f
NucleiTask - Fix Table Producer issue
giovannimalfattore a353f85
NucleiTask - Files renamed
giovannimalfattore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you silencing this error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it is already in ("UpperCamelCase", "lowerCamelCase") format and it is still triggering the error. Probably because of the "_" symbol. As I don't want to change the name from "selection_bit" at the moment, I have chosen to just silence it at moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selection_bitis not lowerCamelCase.selectionBitis lowerCamelCase. Please follow the naming conventions, unless you have a stronger reason to deviate from them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My task won't work if I change that column from selection_bit to selectionBit, unfortunately. I tried to debug the issue, didn't manage. I will keep it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, if it's a compatibility problem with another existing table, that's a different story, of course. If that is the case, please mention it in the exception reason of the disabling comment.