[PWGCF] Fix includes by vkucera · Pull Request #16410 · AliceO2Group/O2Physics

vkucera · 2026-05-27T10:01:24Z

No description provided.

github-actions · 2026-05-27T10:01:43Z

O2 linter results: ❌ 37 errors, ⚠️ 77 warnings, 🔕 0 disabled

vkucera · 2026-05-29T08:59:00Z

@ariedel-cern @isputows @jaelpark @lauraser @lgraczykCern @otonvd @prchakra @shouqiye @SwatiSaha-1997 @victor-gonzalez @wenyaCern
Please merge the PR.

alibuild · 2026-05-30T00:18:46Z

Error while checking build/O2Physics/o2 for 2082fbf at 2026-06-01 11:25:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:227:29: error: 'BestDCAXY' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:228:29: error: 'BestDCAZ' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:1: error: template argument 9 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:1: error: template argument 10 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:19: error: 'LRMftTracksMetadata' does not name a type; did you mean 'LRMidTracksMetadata'?
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:282:29: error: 'BestDCAXY' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:283:29: error: 'BestDCAZ' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:1: error: template argument 9 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:1: error: template argument 10 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:19: error: 'UpcLRMftTracksMetadata' does not name a type; did you mean 'UpcLRMidTracksMetadata'?
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:493:18: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >) (int64_t, const int&, const float&, const float&, float&, o2::aod::fwdtrack::v001::NClusters<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>::type, const float&, const float&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:673:23: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >) (int64_t, const int&, const float&, const float&, float&, o2::aod::fwdtrack::v001::NClusters<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>::type, const float&, const float&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:878:20: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >) (int64_t, const int&, const float&, const float&, float&, o2::aod::fwdtrack::v001::NClusters<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>::type, const float&, const float&)'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:458:9: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:459:22: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:461:29: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:463:29: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:458:9: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:459:22: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:461:29: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:463:29: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:227:29: error: 'BestDCAXY' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:228:29: error: 'BestDCAZ' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:1: error: template argument 9 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:1: error: template argument 10 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:19: error: 'LRMftTracksMetadata' does not name a type; did you mean 'LRMidTracksMetadata'?
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:282:29: error: 'BestDCAXY' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:283:29: error: 'BestDCAZ' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:1: error: template argument 9 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:1: error: template argument 10 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:19: error: 'UpcLRMftTracksMetadata' does not name a type; did you mean 'UpcLRMidTracksMetadata'?
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:349:7: error: inconsistent begin/end types in range-based 'for' statement: 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::unfiltered_const_iterator' {aka 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'} and 'o2::soa::RowViewSentinel'
[0 more errors; see full log]

Full log here.

alibuild · 2026-05-30T15:40:18Z

Error while checking build/O2Physics/staging for 2082fbf at 2026-06-01 09:44:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:227:29: error: 'BestDCAXY' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:228:29: error: 'BestDCAZ' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:1: error: template argument 9 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:1: error: template argument 10 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:19: error: 'LRMftTracksMetadata' does not name a type; did you mean 'LRMidTracksMetadata'?
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:282:29: error: 'BestDCAXY' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:283:29: error: 'BestDCAZ' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:1: error: template argument 9 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:1: error: template argument 10 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:19: error: 'UpcLRMftTracksMetadata' does not name a type; did you mean 'UpcLRMidTracksMetadata'?
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:493:18: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >) (int64_t, const int&, const float&, const float&, float&, o2::aod::fwdtrack::v001::NClusters<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>::type, const float&, const float&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:673:23: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >) (int64_t, const int&, const float&, const float&, float&, o2::aod::fwdtrack::v001::NClusters<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>::type, const float&, const float&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:878:20: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >) (int64_t, const int&, const float&, const float&, float&, o2::aod::fwdtrack::v001::NClusters<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>::type, const float&, const float&)'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:458:9: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:459:22: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:461:29: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:463:29: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:458:9: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:459:22: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:461:29: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/AnalysisHelpers.h:463:29: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:227:29: error: 'BestDCAXY' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:228:29: error: 'BestDCAZ' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:1: error: template argument 9 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:1: error: template argument 10 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:219:19: error: 'LRMftTracksMetadata' does not name a type; did you mean 'LRMidTracksMetadata'?
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1261099976> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:282:29: error: 'BestDCAXY' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:283:29: error: 'BestDCAZ' is not a member of 'o2::aod::fwdtrack'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:1: error: template argument 9 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:1: error: template argument 10 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/DataModel/LongRangeDerived.h:274:19: error: 'UpcLRMftTracksMetadata' does not name a type; did you mean 'UpcLRMidTracksMetadata'?
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:1874:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<2105438721> >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20260601-0000-local1/include/Framework/ASoA.h:2014:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<1172698361>, o2::aod::Hash<2105438721>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:349:7: error: inconsistent begin/end types in range-based 'for' statement: 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::unfiltered_const_iterator' {aka 'o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3108592478>, o2::aod::Hash<1261099976>, o2::aod::Hash<2286545062> > >'} and 'o2::soa::RowViewSentinel'
[0 more errors; see full log]

Full log here.

vkucera · 2026-06-01T11:57:25Z

@ariedel-cern @isputows @jaelpark @lauraser @lgraczykCern @otonvd @prchakra @shouqiye @SwatiSaha-1997 @victor-gonzalez @wenyaCern
Updated and ready.

abilandz · 2026-06-01T12:12:56Z

Dear @vkucera,

For what concerns link - since there is a currently ongoing development locally on the very same task, we will implement directly your minor suggestions into the local version of the task, and they will be in the next PR from our side (we could stash and pull, but this is easier and less error-prone for us - as a rule of thumb we want to avoid resolving merging conflicts at any cost...).

Thanks!

vkucera · 2026-06-01T12:29:56Z

Dear @vkucera,

For what concerns link - since there is a currently ongoing development locally on the very same task, we will implement directly your minor suggestions into the local version of the task, and they will be in the next PR from our side (we could stash and pull, but this is easier and less error-prone for us - as a rule of thumb we want to avoid resolving merging conflicts at any cost...).

Thanks!

Dear @abilandz , when do you plan to open the PR?
IMO, an ongoing local development is not a good reason to block an open PR just because there is a risk of minor conflicts. Conflicts are a normal part of project development and contributors are supposed to know how to resolve them. As you said, in this case the conflicts will be minor and trivial to resolve. There is no need to stash and pull. You can just merge the upstream master branch into your local development branch.

abilandz · 2026-06-01T12:46:31Z

Dear @vkucera,
For what concerns link - since there is a currently ongoing development locally on the very same task, we will implement directly your minor suggestions into the local version of the task, and they will be in the next PR from our side (we could stash and pull, but this is easier and less error-prone for us - as a rule of thumb we want to avoid resolving merging conflicts at any cost...).
Thanks!

Dear @abilandz , when do you plan to open the PR? IMO, an ongoing local development is not a good reason to block an open PR just because there is a risk of minor conflicts. Conflicts are a normal part of project development and contributors are supposed to know how to resolve them. As you said, in this case the conflicts will be minor and trivial to resolve. There is no need to stash and pull. You can just merge the upstream master branch into your local development branch.

Dear @vkucera, we do not have to agree on everything... But I am not ready to defend your statement "conflicts are a normal part of project development" - instead, we should perhaps organize the development in such a way that merging conflicts are minimized. As you can sense from my text, I had some traumatic experiences in the past with resolving merging conflicts, and I doubt there is anybody who is keen on doing that. Also, beware that you speak as a Git expert, while most of new students and new O2 developers are just starting to use Git. In this particular case, merging the upstream master branch into the local development branch will, by definition, result in merge conflicts.

On a side note: perhaps we could try to organize your direct interventions in other developers' code differently? While we all definitely benefit from your expertise and the great effort you are investing in the O2 project, it's not really a pleasant experience that, after each of your direct interventions in our code, we have to stop our work and start resolving merge conflicts.

vkucera · 2026-06-01T15:46:59Z

@abilandz I understand (and know from experience) that resolving merge conflicts can be frustrating and nobody likes it. Of course we should try to minimise them but we cannot avoid them. That's what I meant when I said they are a normal part of project development. And because they are unavoidable, I think that conflict resolving skills are necessary and therefore basic, not something advanced.
For this reason we have references in the documentation to the relevant tutorials and to tools that help with Git operations.
In this specific case of fixing includes, I do this from time to time in bulk over the whole repository so it is common that the changes modify tens or hundreds of files. I hope you understand that it is not possible for me to contact all contributors and coordinate my PRs with theirs.
If you want to avoid these interventions, please verify your list of includes, following the instructions in our documentation.

abilandz · 2026-06-02T07:05:58Z

it is not possible for me to contact all contributors and coordinate my PRs with theirs.

Dear @vkucera, Please nevertheless re-think this part of our Git workflow - making interventions in somebody else's code without any prior announcement, and triggering that way out of the blue merging conflicts to other developers, cannot be the final solution. Thanks for your understanding!

vkucera · 2026-06-02T07:22:40Z

it is not possible for me to contact all contributors and coordinate my PRs with theirs.

Dear @vkucera, Please nevertheless re-think this part of our Git workflow - making interventions in somebody else's code without any prior announcement, and triggering that way out of the blue merging conflicts to other developers, cannot be the final solution. Thanks for your understanding!

Dear @abilandz , please suggest a solution that you would prefer.

abilandz · 2026-06-02T07:46:38Z

it is not possible for me to contact all contributors and coordinate my PRs with theirs.

Dear @vkucera, Please nevertheless re-think this part of our Git workflow - making interventions in somebody else's code without any prior announcement, and triggering that way out of the blue merging conflicts to other developers, cannot be the final solution. Thanks for your understanding!

Dear @abilandz , please suggest a solution that you would prefer.

Dear @vkucera, I can think of two alternative solutions, both of which would avoid merging conflicts:

Your prior announcement would already help a lot, give some time to developers to wrap up and commit their current development. Once you are done with your intervention, they can pull fearlessly and continue with the development.
Make a PR like this one, but which is not binding. Honestly, I prefer to manually implement in my local task your suggestions from this PR and commit them alongside the next PR, rather than approve this PR, merge it into my local branch, and then manually start resolving the merging conflicts locally (yes, as I already wrote, I am traumatized with merging conflicts...)

Fix includes

addac03

vkucera requested review from SwatiSaha-1997, alibuild, ariedel-cern, isputows, jaelpark, lauraser, lgraczykCern, otonvd, prchakra, shouqiye, victor-gonzalez and wenyaCern as code owners May 27, 2026 10:01

github-actions Bot added pwgcf datamodel labels May 27, 2026

github-actions Bot changed the title ~~Fix includes~~ [PWGCF] Fix includes May 27, 2026

vkucera mentioned this pull request May 27, 2026

Include What You Use #8357

Open

ariedel-cern previously approved these changes May 27, 2026

View reviewed changes

SwatiSaha-1997 previously approved these changes May 27, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/master' into fixes-PWGCF

2082fbf

vkucera dismissed stale reviews from SwatiSaha-1997 and ariedel-cern via 2082fbf May 27, 2026 14:07

SwatiSaha-1997 enabled auto-merge (squash) May 29, 2026 09:13

SwatiSaha-1997 previously approved these changes May 29, 2026

View reviewed changes

ariedel-cern previously approved these changes May 29, 2026

View reviewed changes

Merge branch 'master' into fixes-PWGCF

cdff16e

Fix compilation

4c1805a

vkucera dismissed stale reviews from ariedel-cern and SwatiSaha-1997 via 4c1805a June 1, 2026 10:28

More fixes

2701597

vkucera requested a review from abilandz as a code owner June 1, 2026 11:54

jaelpark approved these changes Jun 1, 2026

View reviewed changes

ariedel-cern approved these changes Jun 1, 2026

View reviewed changes

abilandz approved these changes Jun 2, 2026

View reviewed changes

lauraser approved these changes Jun 2, 2026

View reviewed changes

SwatiSaha-1997 merged commit 27f1df6 into AliceO2Group:master Jun 2, 2026
14 of 15 checks passed

vkucera deleted the fixes-PWGCF branch June 2, 2026 06:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PWGCF] Fix includes#16410

[PWGCF] Fix includes#16410
SwatiSaha-1997 merged 5 commits into
AliceO2Group:masterfrom
vkucera:fixes-PWGCF

vkucera commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026 •

edited

Loading

Uh oh!

vkucera commented May 29, 2026

Uh oh!

alibuild commented May 30, 2026 •

edited

Loading

Uh oh!

alibuild commented May 30, 2026 •

edited

Loading

Uh oh!

vkucera commented Jun 1, 2026 •

edited

Loading

Uh oh!

abilandz commented Jun 1, 2026

Uh oh!

vkucera commented Jun 1, 2026

Uh oh!

abilandz commented Jun 1, 2026 •

edited

Loading

Uh oh!

vkucera commented Jun 1, 2026

Uh oh!

Uh oh!

abilandz commented Jun 2, 2026

Uh oh!

vkucera commented Jun 2, 2026

Uh oh!

abilandz commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

Conversation

vkucera commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented May 29, 2026

Uh oh!

alibuild commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abilandz commented Jun 1, 2026

Uh oh!

vkucera commented Jun 1, 2026

Uh oh!

abilandz commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Jun 1, 2026

Uh oh!

Uh oh!

abilandz commented Jun 2, 2026

Uh oh!

vkucera commented Jun 2, 2026

Uh oh!

abilandz commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

github-actions Bot commented May 27, 2026 •

edited

Loading

alibuild commented May 30, 2026 •

edited

Loading

alibuild commented May 30, 2026 •

edited

Loading

vkucera commented Jun 1, 2026 •

edited

Loading

abilandz commented Jun 1, 2026 •

edited

Loading