Making Vertico's implementation of completing-read-multiple remove an entry if it is repeated?

[kisaragi-hiu]

Specificically, org-set-tags-command under vertico-mode would set tags to :tag1:tag2:tag1: (repeated) if one selects tag1 when the heading has :tag1:tag2: before. There is an issue about this downstream in Doom Emacs doomemacs/doomemacs#7632. Some, including me, expect this to remove the tag, like counsel-org-tag does.

If Vertico's completing-read-multiple is somehow made to remove tag1 when it is already in the initial-input, this would improve org-set-tags-command (so one can remove tags without having to directly edit the input string) and possibly other commands.

But the blast radius is also obviously pretty wide (what about commands that actually don't care about duplicates). I'm not sure. Is this idea as bad as I'm expecting?

If touching completing-read-multiple really is too disruptive, maybe implementing this as consult-org-tag is what should be done instead. (I see someone mentioned they had an implementation in 2020 but a PR seems to never have happened)

[minad]

If the prompt already contains :tag1:tag2: you can simply select the prompt and press RET. Then the result will be :tag1:tag2:. If you add tag1 via Vertico, of course the returned result will be :tag1:tag2:tag1:. It seems to be the responsibility of org-set-tags-command to filter out duplicates, if this is desired. completing-read-multiple doesn't guarantee a list of unique values as far as I know, since the duplicates might be desired in some cases.

EDIT: I should add Vertico doesn't provide a completing-read-multiple implementation. It provides just the UI for the default completing-read-multiple function.

[kisaragi-hiu]

I see. I was under the impression that Vertico's advice on completing-read-multiple did a lot more than it actually does 🤦

I've ported counsel-org-tag to Consult and opened a PR then.